Conversation
In order to verify performance fixes (like #451 and #454), it would be helpful to be able to write a JMH benchmark and quickly measure the impact. This adds a benchmark module to the Gradle build. CI only verifies the build of the benchmarks. Added a README showing how to add benchmarks and measure improvements locally. Instead of outputting JSON or other format, created a jq script to roughly print out output similar to benchstat for Go.
stefanvanburen
approved these changes
Apr 23, 2026
Member
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
nothing blocking, just wondering
| @@ -0,0 +1,101 @@ | |||
| // Copyright 2023-2026 Buf Technologies, Inc. | |||
Member
There was a problem hiding this comment.
nit: think we ought to bump license-header.years in general; can be separate?
Member
Author
There was a problem hiding this comment.
You're looking at an older version - this is already bumped:
protovalidate-java/gradle.properties
Lines 7 to 8 in f05bf07
stefanvanburen
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to verify performance fixes (like #451 and #454), it would be helpful to be able to write a JMH benchmark and quickly measure the impact.
This adds a benchmark module to the Gradle build. CI only verifies the build of the benchmarks. Added a README showing how to add benchmarks and measure improvements locally.
Instead of outputting JSON or other format, created a jq script to roughly print out output similar to benchstat for Go.